Removing rule severity for a category of analyzer rules + switching some rules from dotnet_diagnostic syntax #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome rules from dotnet_diagnostic syntax
… in linux when running dotnet format
|
111 |
badrishc
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that severity of specific "dotnet_diagnostic" style rules take precedence over severity of category of analyzer rules BUT severity of category of analyzer rules takes precedence over dotnet_style_ / csharp_style_ rules.
More about this here.
So in essence, any specified severity in dotnet_style_ / csharp_style_ rules is effectively ignored and marked as "error".
I think then the "appropriate" way to do this is to remove the category severity of error, and run "dotnet format --verify-no-changes" in the CI to make sure that current formatting follows the rules.
LMK if you have any comments.