Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication Checkpoint Fix #248

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

vazois
Copy link
Contributor

@vazois vazois commented Apr 6, 2024

This PR contains the following changes:

  • Separate replication-id used for signing checkpoints vs the replication-id being recovered from an existing checkpoint.
  • Set replication-id of ReplicationLogCheckpointManager for signing checkpoints only at initialization or during failover.
  • Introduce checks to ensure validity of metadata when send a checkpoint to an attaching.
  • Refactor replication info to avoid using explicit count calculations.
  • Simplify constructors for ClusterManager, ReplicationManager and FailoverManager.
  • Push more fixed error message to CmdStrings.
  • Refactor cluster tests to use common backoff for polling the server.
  • Misc code cleanup and simplication

@vazois vazois requested a review from badrishc April 6, 2024 02:21
@vazois vazois merged commit 5d394d3 into microsoft:main Apr 9, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants