Apply CA1837 and CA1840 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entThread.ManagedThreadId
badrishc
approved these changes
Apr 23, 2024
TedHartMS
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two analyzers from Performance-category use specific intrinsic methods to fetch current
ProcessIdand currentThreadIdwhich are faster. Doesn't matter for the hit in tests but reduces analyzer noise.Might help in the. edit:ConcurrentCountercaseThread.CurrentThread.ManagedThreadIdis specialized to the direct helper call too, oh well.. atleast it's little bit smaller IL I guess (2 -> 1 getter calls).. dotnet/runtime#91205 might improve things in future too.Random note: I wonder how
ThreadLocalwould fare against the current cache-line partitionedConcurrentCounterin Tsavorite (i.e. https://twitter.com/EgorBo/status/1697579906106896652) (TODO: Benchmark this)