Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mvn install #2

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Fix mvn install #2

merged 2 commits into from
Aug 6, 2021

Conversation

dsgrieve
Copy link
Member

@dsgrieve dsgrieve commented Aug 6, 2021

One used to have to run mvn install on each pom file. The idea behind having to do this was allowing the zip files to be individually versioned. But this causes all sorts of trouble because it is an atypical way of doing mvn projects.

This PR makes the sub-directories modules of the parent so that running mvn install from the top-level does what one would normally expect.

Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-290 lines of Maven config? Approved!

@karianna karianna merged commit 883f5fe into main Aug 6, 2021
@karianna karianna added the enhancement New feature or request label Aug 6, 2021
@dsgrieve dsgrieve deleted the fix-mvn-install branch October 1, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants