refactor: remove unused code

microsoft · Apr 20, 2022 · 99f423c · 99f423c
1 parent 4c0c81a
commit 99f423c
Show file tree

Hide file tree

Showing 17 changed files with 79 additions and 195 deletions.
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/GCEvent.java b/api/src/main/java/com/microsoft/gctoolkit/event/GCEvent.java
@@ -86,83 +86,83 @@ public GarbageCollectionTypes getGarbageCollectionType() {
         return gcType;
     }
 
-    /**
-     *
-     * @return is a Z cycle
-     */
-    public boolean isZGC() { return false; }
-
-    /**
-     *
-     * @return is a young collection
-     */
-    public boolean isYoung() {
-        return false;
-    }
-
-    /**
-     *
-     * @return is a full collection
-     */
-    public boolean isFull() {
-        return false;
-    }
-
-    /**
-     *
-     * @return is a concurrent phase
-     */
-    public boolean isConcurrent() {
-        return false;
-    }
-
-    /**
-     *
-     * @return is a G1 young collection
-     */
-    public boolean isG1Young() {
-        return false;
-    }
-
-    /**
-     *
-     * @return is a G1 mixed collection
-     */
-    public boolean isG1Mixed() {
-        return false;
-    }
-
-    /**
-     *
-     * @return is a G1 concurrent phase
-     */
-    public boolean isG1Concurrent() {
-        return false;
-    }
-
-    /**
-     *
-     * @return triggered by System.gc() or Runtime.gc().
-     */
-    public boolean isSystemGC() {
-        return false;
-    }
-
-    /**
-     *
-     * @return the type is a CMF
-     */
-    public boolean isConcurrentModeFailure() {
-        return false;
-    }
-
-    /**
-     *
-     * @return the type is a CMI
-     */
-    public boolean isConcurrentModeInterrupted() {
-        return false;
-    }
+//    /**
+//     *
+//     * @return is a Z cycle
+//     */
+//    public boolean isZGC() { return false; }
+//
+//    /**
+//     *
+//     * @return is a young collection
+//     */
+//    public boolean isYoung() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return is a full collection
+//     */
+//    public boolean isFull() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return is a concurrent phase
+//     */
+//    public boolean isConcurrent() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return is a G1 young collection
+//     */
+//    public boolean isG1Young() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return is a G1 mixed collection
+//     */
+//    public boolean isG1Mixed() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return is a G1 concurrent phase
+//     */
+//    public boolean isG1Concurrent() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return triggered by System.gc() or Runtime.gc().
+//     */
+//    public boolean isSystemGC() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return the type is a CMF
+//     */
+//    public boolean isConcurrentModeFailure() {
+//        return false;
+//    }
+//
+//    /**
+//     *
+//     * @return the type is a CMI
+//     */
+//    public boolean isConcurrentModeInterrupted() {
+//        return false;
+//    }
 
     /**
      *
@@ -171,7 +171,7 @@ public boolean isConcurrentModeInterrupted() {
      * @param y is a value
      * @return boolean is diff is greater than threshold
      */
-    private static boolean withinThreshold(final double x, final double y) {
+    private boolean withinThreshold(final double x, final double y) {
         return TIMESTAMP_THRESHOLD > Math.abs(x - y);
     }
 

diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1FullGC.java b/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1FullGC.java
@@ -22,10 +22,6 @@ public G1FullGC(DateTimeStamp timeStamp, GarbageCollectionTypes type, GCCause ca
         super(timeStamp, type, cause, pauseTime);
     }
 
-    public boolean isFull() {
-        return true;
-    }
-
     public void addInternalPhase(String internalPhase, Double duration) {
         internalPhaseTimes.put(internalPhase, duration);
     }

diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Remark.java b/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Remark.java
@@ -36,5 +36,4 @@ public double getUnloadingTime() {
         return this.unloadingTime;
     }
 
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1SystemGC.java b/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1SystemGC.java
@@ -11,14 +11,4 @@ public class G1SystemGC extends G1FullGC {
     public G1SystemGC(DateTimeStamp timeStamp, double pauseTime) {
         super(timeStamp, GarbageCollectionTypes.SystemGC, GCCause.JAVA_LANG_SYSTEM, pauseTime);
     }
-
-    public boolean isFull() {
-        return true;
-    }
-
-    public boolean isSystemGC() {
-        return true;
-    }
-
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Trap.java b/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Trap.java
@@ -69,48 +69,6 @@ public GarbageCollectionTypes getGarbageCollectionType() {
         return super.getGarbageCollectionType();
     }
 
-    @Override
-    public boolean isYoung() {
-        trap(new Exception());
-        return super.isYoung();
-    }
-
-    @Override
-    public boolean isFull() {
-        trap(new Exception());
-        return super.isFull();
-    }
-
-    @Override
-    public boolean isConcurrent() {
-        trap(new Exception());
-        return super.isConcurrent();
-    }
-
-    @Override
-    public boolean isG1Young() {
-        trap(new Exception());
-        return super.isG1Young();
-    }
-
-    @Override
-    public boolean isG1Mixed() {
-        trap(new Exception());
-        return super.isG1Mixed();
-    }
-
-    @Override
-    public boolean isG1Concurrent() {
-        trap(new Exception());
-        return super.isG1Concurrent();
-    }
-
-    @Override
-    public boolean isSystemGC() {
-        trap(new Exception());
-        return super.isSystemGC();
-    }
-
     @Override
     public void addMemorySummary(MemoryPoolSummary eden, SurvivorMemoryPoolSummary survivor, MemoryPoolSummary heap) {
         trap(new Exception());

diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Young.java b/api/src/main/java/com/microsoft/gctoolkit/event/g1gc/G1Young.java
@@ -257,4 +257,5 @@ public Stream<String> postEvacuateCSetPhaseNames() {
     public double postEvacuateCSetPhaseDuration(String name) {
         return postEvacuateCSetPhase.get(name);
     }
+
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/CMSConcurrentEvent.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/CMSConcurrentEvent.java
@@ -25,9 +25,4 @@ public double getWallClockTime() {
         return wallClockTime;
     }
 
-    @Override
-    public boolean isConcurrent() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/ConcurrentModeFailure.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/ConcurrentModeFailure.java
@@ -11,9 +11,4 @@ public class ConcurrentModeFailure extends FullGC {
     public ConcurrentModeFailure(DateTimeStamp timeStamp, GCCause cause, double duration) {
         super(timeStamp, GarbageCollectionTypes.ConcurrentModeFailure, cause, duration);
     }
-
-    @Override
-    public boolean isConcurrentModeFailure() {
-        return true;
-    }
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/ConcurrentModeInterrupted.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/ConcurrentModeInterrupted.java
@@ -15,10 +15,4 @@ public ConcurrentModeInterrupted(DateTimeStamp timeStamp, GarbageCollectionTypes
     public ConcurrentModeInterrupted(DateTimeStamp timeStamp, GCCause cause, double duration) {
         this(timeStamp, GarbageCollectionTypes.ConcurrentModeInterrupted, cause, duration);
     }
-
-    @Override
-    public boolean isConcurrentModeInterrupted() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/DefNew.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/DefNew.java
@@ -11,10 +11,4 @@ public class DefNew extends GenerationalGCPauseEvent {
     public DefNew(DateTimeStamp timeStamp, GCCause cause, double duration) {
         super(timeStamp, GarbageCollectionTypes.DefNew, cause, duration);
     }
-
-    @Override
-    public boolean isYoung() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/FullGC.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/FullGC.java
@@ -26,10 +26,4 @@ public int getDutyCycle() {
         return dutyCycle;
     }
 
-    @Override
-    public boolean isFull() {
-        return true;
-    }
-
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/PSYoungGen.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/PSYoungGen.java
@@ -15,10 +15,4 @@ public PSYoungGen(DateTimeStamp timeStamp, GarbageCollectionTypes type, GCCause
     public PSYoungGen(DateTimeStamp timeStamp, GCCause cause, double duration) {
         super(timeStamp, GarbageCollectionTypes.PSYoungGen, cause, duration);
     }
-
-    @Override
-    public boolean isYoung() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/ParNew.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/ParNew.java
@@ -37,9 +37,4 @@ public TLABSummary getTlabSummary() {
         return tlabSummary;
     }
 
-    @Override
-    public boolean isYoung() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/ParNewPromotionFailed.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/ParNewPromotionFailed.java
@@ -15,10 +15,4 @@ public ParNewPromotionFailed(DateTimeStamp dateTimeStamp, GCCause gcCause, doubl
     public ParNewPromotionFailed(DateTimeStamp dateTimeStamp, double pauseTime) {
         this(dateTimeStamp, GCCause.PROMOTION_FAILED, pauseTime);
     }
-
-    @Override
-    public boolean isYoung() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/SystemGC.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/SystemGC.java
@@ -19,10 +19,4 @@ public SystemGC(DateTimeStamp timeStamp, GCCause cause, double duration) {
     public SystemGC(DateTimeStamp timeStamp, double duration) {
         this(timeStamp, GarbageCollectionTypes.SystemGC, GCCause.JAVA_LANG_SYSTEM, duration);
     }
-
-    @Override
-    public boolean isSystemGC() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/generational/YoungGC.java b/api/src/main/java/com/microsoft/gctoolkit/event/generational/YoungGC.java
@@ -15,10 +15,4 @@ public YoungGC(DateTimeStamp timeStamp, GarbageCollectionTypes gcType, GCCause c
     public YoungGC(DateTimeStamp timeStamp, GCCause cause, double duration) {
         this(timeStamp, GarbageCollectionTypes.GC, cause, duration);
     }
-
-    @Override
-    public boolean isYoung() {
-        return true;
-    }
-
 }
diff --git a/api/src/main/java/com/microsoft/gctoolkit/event/zgc/ZGCCycle.java b/api/src/main/java/com/microsoft/gctoolkit/event/zgc/ZGCCycle.java
@@ -24,9 +24,6 @@ public ZGCCycle(DateTimeStamp timeStamp, GarbageCollectionTypes gcType, double d
         super(timeStamp, gcType, duration);
     }
 
-    @Override
-    public boolean isZGC() { return true; }
-
     private DateTimeStamp pauseMarkStartTimeStamp;
     private double pauseMarkStartDuration;