Adding install and uninstall scripts that use sfctl #1
Conversation
|
@samedder, |
There was a problem hiding this comment.
General comment - Let's update the install/uninstall files already present there, instead of new files, since once we start supporting CLI 2.0 we would not support CLI 1.0 any more. Also, then there would not be any change required in the other places where they are referenced - e.g. the index.js, documentations etc.
Also, please update the version to possible next version (e.g. 0.0.0 -> 0.0.1) in package.json for NPM to consume it.
| @@ -0,0 +1,5 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
as mentioned in the other PR, let's update the existing scripts.
generators/guestbinary/index.js
Outdated
| @@ -188,6 +188,26 @@ module.exports = generators.Base.extend({ | |||
| appTypeName: appTypeName | |||
| } | |||
| ); | |||
|
|
|||
| this.fs.copyTpl( | |||
There was a problem hiding this comment.
this change here would not be needed if we update the existing script.
|
Looks good. Merging. |
No description provided.