Fix sparse-checkout set crashes (#607)

microsoft · Sep 20, 2023 · 00315c6 · 00315c6
2 parents 6d120bf + c9f342c
commit 00315c6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/sparse-index.c b/sparse-index.c
@@ -242,7 +242,7 @@ static int add_path_to_index(const struct object_id *oid,
 	size_t len = base->len;
 
 	if (S_ISDIR(mode)) {
-		int dtype;
+		int dtype = DT_DIR;
 		size_t baselen = base->len;
 		if (!ctx->pl)
 			return READ_TREE_RECURSIVE;
@@ -360,7 +360,7 @@ void expand_index(struct index_state *istate, struct pattern_list *pl)
 		struct cache_entry *ce = istate->cache[i];
 		struct tree *tree;
 		struct pathspec ps;
-		int dtype;
+		int dtype = DT_UNKNOWN;
 
 		if (!S_ISSPARSEDIR(ce->ce_mode)) {
 			set_index_entry(full, full->cache_nr++, ce);
@@ -371,7 +371,7 @@ void expand_index(struct index_state *istate, struct pattern_list *pl)
 		if (pl &&
 		    path_matches_pattern_list(ce->name, ce->ce_namelen,
 					      NULL, &dtype,
-					      pl, istate) == NOT_MATCHED) {
+					      pl, full) == NOT_MATCHED) {
 			set_index_entry(full, full->cache_nr++, ce);
 			continue;
 		}
@@ -399,6 +399,7 @@ void expand_index(struct index_state *istate, struct pattern_list *pl)
 	}
 
 	/* Copy back into original index. */
+	istate->name_hash_initialized = full->name_hash_initialized;
 	memcpy(&istate->name_hash, &full->name_hash, sizeof(full->name_hash));
 	memcpy(&istate->dir_hash, &full->dir_hash, sizeof(full->dir_hash));
 	istate->sparse_index = pl ? INDEX_PARTIALLY_SPARSE : INDEX_EXPANDED;

diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh
@@ -311,6 +311,22 @@ test_expect_success 'root directory cannot be sparse' '
 	test_cmp expect actual
 '
 
+test_expect_success 'sparse-checkout with untracked files and dirs' '
+	init_repos &&
+
+	# Empty directories outside sparse cone are deleted
+	run_on_sparse mkdir -p deep/empty &&
+	test_sparse_match git sparse-checkout set folder1 &&
+	test_must_be_empty sparse-checkout-err &&
+	run_on_sparse test_path_is_missing deep &&
+
+	# Untracked files outside sparse cone are not deleted
+	run_on_sparse touch folder1/another &&
+	test_sparse_match git sparse-checkout set folder2 &&
+	grep "directory ${SQ}folder1/${SQ} contains untracked files" sparse-checkout-err &&
+	run_on_sparse test_path_exists folder1/another
+'
+
 test_expect_success 'status with options' '
 	init_repos &&
 	test_sparse_match ls &&