Code changes for closing 110 and 111 #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than 65536 vertices. Added support for ACCESSOR_COLOR_1, ACCESSOR_COLOR_2, and ACCESSOR_COLOR_3
|
It looks like your changes are causing a unit test failure. Can you take a look? |
|
Note that you should be generating the solution with CMake. Don't use the sln. We are going to remove the sln/vcxproj files eventually. |
|
Closing due to lack of activity. Please reopen if it is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear Sir, please accept my code changes regarding the following issues:
Closes #110 about comments on how to Serialize big models
Closes #111 about how to support more vertex colors
thanks,
Dimitrios Ververidis