Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glTF 1.0 Deserialize Unit Tests #37

Closed
chriche-ms opened this issue Apr 10, 2019 · 2 comments
Closed

Update glTF 1.0 Deserialize Unit Tests #37

chriche-ms opened this issue Apr 10, 2019 · 2 comments
Labels
invalid This doesn't seem right

Comments

@chriche-ms
Copy link
Member

The following test inputs are using the 1.0 spec!

c_negativeAccessorOffset
c_negativeAccessorCount
c_negativeBufferLength
c_negativeBufferViewOffset
c_negativeBufferViewLength
c_invalidAccessorComponentType

The tests need rewriting so that:

  1. The test input is written against the 2.0 spec
  2. The tests need an assert adding, one that checks that the throw exception's message matches the known schema violation in the input manifest.

Consider also adding at least one assert for the following tests or test inputs:

c_extraFieldsJson
SerializerGLTFTests_InvalidDefaultScene
c_validPrimitiveNoIndices
c_invalidPrimitiveAccessorComponentType
c_invalidPrimitiveAccessorType

@chriche-ms chriche-ms added the invalid This doesn't seem right label Apr 10, 2019
@wangdemon
Copy link

This library doesn't seem to support version 1.0. How do you parse gltf of version 1.0?

@bghgary
Copy link
Contributor

bghgary commented Apr 1, 2022

I don't think there is support for 1.0. Why do you need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants