Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build asset JSON: handle go.*.src.tar.gz files, improve errors #24

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

dagood
Copy link
Member

@dagood dagood commented Feb 7, 2022

Check for .src.tar.gz and avoid trying to parse it as a binary build, because it will fail. Also improve the error message in case of failure, and store the source tarball URL in the build asset JSON to make the file more complete.

@dagood dagood requested a review from a team as a code owner February 7, 2022 23:16
@dagood
Copy link
Member Author

dagood commented Feb 7, 2022

I'm running a test Go internal rolling build with this change vendored in here: https://dev.azure.com/dnceng/internal/_build/results?buildId=1598321&view=results.

@dagood
Copy link
Member Author

dagood commented Feb 8, 2022

@microsoft/golang-compiler PTAL
The test Go internal build succeeded, so this should be good to go.

@dagood
Copy link
Member Author

dagood commented Feb 8, 2022

I noticed this leaves a blank-ish entry in the build asset JSON because the checksum file of the source tarball isn't handled correctly:

    {
      "env": {
        "GOARCH": "",
        "GOOS": ""
      },
      "sha256": "4f1f09428fcb78786f75eff612e09f9e8271caff03e834f806aa9d967d17544d",
      "url": ""
    },

Working on it. [Done.]

https://dev.azure.com/dnceng/internal/_build/results?buildId=1598617&view=results

@dagood dagood merged commit 51df6c5 into microsoft:main Feb 8, 2022
@dagood dagood deleted the dev/dagood/asset-json-archive branch February 8, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants