-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub tagging and release creation automation using GitHub and Azure Pipelines APIs #40
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c1d442e
Switch to interface-based subcommand system
dagood b2b796a
Add GitHub tagging and release creation automation
dagood 2b4799b
Clarify reason for defaultless goReleaseConfigVariableGroup
dagood ecb662b
Update cmd/git-go-patch/apply.go
dagood d796794
Change Option to struct, merge in OptionArgTaker
dagood 03783c5
Change set to set-azdo-variable
dagood 3754403
Centralize goDir calculation in findProjectRoots
dagood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
extract,
applyand
rebase` commands have the following pattern:Is it worth factoring that out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see
rootDir, goDir, err := findProjectRoots()
working out.I'd probably want to rename to
projectDir, submoduleDir, err := findProjectRoots()
to be more forward-looking, because I think we'll be generalizing the patching tools beyond our forks. ThefindProjectRoots
function will then let us migrate off the hard-codedgo
subdir in one place (finding/reading a config file instead).These lines are only touched by this PR to change the indentation, but it would be pretty hard to mess up a refactor like this, so I might as well while it's in mind.