Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make README field flexible in manifest.json model #46

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Make README field flexible in manifest.json model #46

merged 1 commit into from
Jun 21, 2022

Conversation

dagood
Copy link
Member

@dagood dagood commented Jun 8, 2022

This PR made dockerupdate start failing in the nightly branch:

The model change from "readme": "README.md" to "readme": { "path": "README.md" } made dockerupdate stop being able to marshal the JSON. Simple fix: model it as interface{} rather than string.

In the future, this kind of break will be caught by running dockerupdate during go-images CI to ensure repeatability:

@dagood dagood requested a review from a team as a code owner June 8, 2022 23:40
@dagood dagood merged commit 1c53b8c into microsoft:main Jun 21, 2022
@dagood dagood deleted the dev/dagood/fix-readme-break branch June 21, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmuntal qmuntal qmuntal approved these changes

@chsienki chsienki chsienki approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dagood @qmuntal @chsienki