Add fuzz target bucketization, more jobs #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested changes
Sep 26, 2022
eng/pipelines/jobs/fuzz.yml
Outdated
| go run . -v -fuzztime ${{ parameters.fuzztime }} | ||
| $(cdFuzzCrypto) | ||
| go env | ||
| $(setExperiment)${{ parameters.goExperiment }} |
There was a problem hiding this comment.
Could we use AzDO env instad of setting the experiment via bash or cmd notation?
Lik this:
- script: |
go env
go run ...
displayName: Fuzz
env: ${{ parameters.goExperiment }}
There was a problem hiding this comment.
True. Also workingDirectory to get rid of the other variable.
There was a problem hiding this comment.
Ah right, env entries don't show up in the build logs. 😬 I usually stick with scripts with set -x for reproducibility/comprehensibility. (Although only on Linux.)
In this case env is perfectly fine because go env prints out the value anyway.
Co-authored-by: Quim Muntal <qmuntaldiaz@microsoft.com>
qmuntal
approved these changes
Sep 26, 2022
chsienki
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't sure we have enough fuzz time with one agent running through each target sequentially over an hour, so this PR distributes the targets between several jobs. (#63 (comment))
Distributing the targets between agents is generally more effective than running every target on multiple agents because Go fuzz testing builds up a local cache of interesting data points that it uses to refine its search for issues, guided by coverage.
This PR doesn't fix the existing issues we've been having with memory usage. These seem to actually be issues in the code under test, not the infra, so we can/will fix these as followup and hopefully end up with green fuzz test runs.
Test build I triggered: https://dev.azure.com/dnceng/internal/_build/results?buildId=2002188&view=results