ColumnType methods should not panic if column type is unimplemented #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kellymtrinh
changed the title
shueybubbles
added
bug
shueybubbles
reviewed
Jun 8, 2022
| @@ -1114,7 +1114,7 @@ func makeGoLangScanType(ti typeInfo) reflect.Type { | |||
| case typeVariant: | |||
| return reflect.TypeOf(nil) | |||
| default: | |||
| panic(fmt.Sprintf("not implemented makeGoLangScanType for type %d", ti.TypeId)) | |||
| return reflect.TypeOf(new(interface{})).Elem() | |||
There was a problem hiding this comment.
Move this common code into a helper function that also logs the type name so developers can see when this is happening if they hook up driver logs in their app.
|
Please add a test that shows the application-level change this enables. What functionality does this light up ? |
|
Please update changelog.md in the root with a description of the change. |
|
@kellymtrinh Are you still planning to complete this PR? thx |
|
Closing because I will not be able to pick this up again soon. Appreciate the review and I still think this is a good first issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #31
ColumnType methods should return nil values instead of panicking when column types are unimplemented. Current behavior, which panics, means calling
ColumnTypes()or related methods in thedatabase/sqllib panics if I'm doing something likeselect *on a table with an unsupported column (or trying to use the driver for generic queries). Matching the spec would let clients handle the cases.This matches the documentation in the database/sql package for drivers: