Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for federated authentication with provided access token when prelogin doesnt return preloginFEDAUTHREQUIRED #85

Merged
merged 8 commits into from
Feb 2, 2023

Conversation

mattgillard
Copy link

This situation occurs with AWS RDS Proxy for MS SQL server as an example but may occur elsewhere.
The solution is to bypass the error message if we are not going through an ADAL workflow.

This resolves #84

@mattgillard
Copy link
Author

@microsoft-github-policy-service agree

@shueybubbles
Copy link
Collaborator

thx for adding the example!

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mattgillard
Copy link
Author

i repushed with go.{mod|sum} files so hopefully it passes integration tests.

@shueybubbles
Copy link
Collaborator

I need to figure out why this test is unreliable. TestMessageQueueWithErrors

@shueybubbles shueybubbles merged commit f481f92 into microsoft:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants