Skip to content

Commit

Permalink
Remove unused winName, extract more into Windows alignment consts
Browse files Browse the repository at this point in the history
Signed-off-by: Davis Goodin <dagood@microsoft.com>
  • Loading branch information
dagood committed Jan 16, 2024
1 parent 91336b4 commit f9a3551
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions fileinfo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,31 +138,30 @@ func TestGetFileStandardInfo_Directory(t *testing.T) {
func TestFileInfoStructAlignment(t *testing.T) {
//nolint:revive // SNAKE_CASE is not idiomatic in Go, but aligned with Win32 API.
const (
exampleLARGE_INTEGER uint64 = 0
exampleULONGLONG uint64 = 0
alignLARGE_INTEGER = unsafe.Alignof(uint64(0))
alignULONGLONG = unsafe.Alignof(uint64(0))
)
tests := []struct {
name string
actualAlign uintptr
actualSize uintptr
winName string
expectedAlignment uintptr
}{
{
// alignedFileBasicInfo is passed to the Windows API rather than FileBasicInfo.
"alignedFileBasicInfo", unsafe.Alignof(alignedFileBasicInfo{}), unsafe.Sizeof(alignedFileBasicInfo{}),
// https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_basic_info
"FILE_BASIC_INFO", unsafe.Alignof(exampleLARGE_INTEGER),
alignLARGE_INTEGER,
},
{
"FileStandardInfo", unsafe.Alignof(FileStandardInfo{}), unsafe.Sizeof(FileStandardInfo{}),
// https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_standard_info
"FILE_STANDARD_INFO", unsafe.Alignof(exampleLARGE_INTEGER),
alignLARGE_INTEGER,
},
{
"FileIDInfo", unsafe.Alignof(FileIDInfo{}), unsafe.Sizeof(FileIDInfo{}),
// https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_id_info
"FILE_ID_INFO", unsafe.Alignof(exampleULONGLONG),
alignULONGLONG,
},
}
for _, tt := range tests {
Expand Down

0 comments on commit f9a3551

Please sign in to comment.