Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corruption in x86 callback #214

Merged
merged 1 commit into from Jul 20, 2021
Merged

Fix corruption in x86 callback #214

merged 1 commit into from Jul 20, 2021

Conversation

kylewo
Copy link
Contributor

@kylewo kylewo commented Jun 14, 2021

When running on x86, the provider callback doesn't function correctly because two of the arguments are ULONGLONG's (64-bit), which does not align with the uintptr on x86 (32-bit).

This change splits the function into two platform-specific versions to avoid the issue.

@kylewo kylewo requested a review from a team as a code owner June 14, 2021 22:01
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice find!

@kevpar kevpar merged commit 8f85a06 into microsoft:master Jul 20, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants