Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/feat: Implementation of Minute-Based Rate Limiting in CommunityReportsExtractor Using asyncio and async_mode #373

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

glide-the
Copy link
Contributor

Description

RateLimiter: The original TpmRpmLLMLimiter strategy did not account for minute-based rate limiting when scheduled. The RateLimiter was introduced to ensure that the CommunityReportsExtractor could be scheduled to adhere to rate configurations on a per-minute basis.

RateLimiter scheduled: using asyncio and async_mode

Additionally, some key loading issues for rpm = "REQUESTS_PER_MINUTE" and tpm = "TOKENS_PER_MINUTE" were fixed. Configuration loading was also enhanced to include temperature = "TEMPERATURE" and top_p = "TOP_P" settings.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.

…or minute-based rate limiting when scheduled. The RateLimiter was introduced to ensure that the CommunityReportsExtractor could be scheduled to adhere to rate configurations on a per-minute basis.

RateLimiter scheduled: using asyncio and async_mode

Additionally, some key loading issues for rpm = "REQUESTS_PER_MINUTE" and tpm = "TOKENS_PER_MINUTE" were fixed. Configuration loading was also enhanced to include temperature = "TEMPERATURE" and top_p = "TOP_P" settings.
@glide-the glide-the requested a review from a team as a code owner July 5, 2024 06:44
glide-the and others added 5 commits July 5, 2024 14:48
… and tpm = "TOKENS_PER_MINUTE" were fixed. Configuration loading was also enhanced to include temperature = "TEMPERATURE" and top_p = "TOP_P" settings.
Copy link
Contributor

@AlonsoGuevara AlonsoGuevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end, works as expected. Added missing requirements to clear checks and to comply with code style. Thanks for your contribution!

@AlonsoGuevara AlonsoGuevara merged commit 6865d60 into microsoft:main Jul 5, 2024
4 of 10 checks passed
jtruxon pushed a commit to jtruxon/graphrag that referenced this pull request Jul 5, 2024
…eportsExtractor Using asyncio and async_mode (microsoft#373)

* RateLimiter: The original TpmRpmLLMLimiter strategy did not account for minute-based rate limiting when scheduled. The RateLimiter was introduced to ensure that the CommunityReportsExtractor could be scheduled to adhere to rate configurations on a per-minute basis.

RateLimiter scheduled: using asyncio and async_mode

Additionally, some key loading issues for rpm = "REQUESTS_PER_MINUTE" and tpm = "TOKENS_PER_MINUTE" were fixed. Configuration loading was also enhanced to include temperature = "TEMPERATURE" and top_p = "TOP_P" settings.

* RateLimiter scheduled: using asyncio and async_mode

* Additionally, some key loading issues for rpm = "REQUESTS_PER_MINUTE" and tpm = "TOKENS_PER_MINUTE" were fixed. Configuration loading was also enhanced to include temperature = "TEMPERATURE" and top_p = "TOP_P" settings.

* Format

* Semversioner

* Format and cleanup

---------

Co-authored-by: Alonso Guevara <alonsog@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants