Similarity Augmented Graph Matching #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for graspologic ready! Built with commit 9dd7e34 |
|
@dwaynepryce @bdpedigo @alyakin314 @Nyecarr @j1c i think this is ready for review if anyone has time to give it a look. Thanks! |
nicaurvi
reviewed
Feb 1, 2021
nicaurvi
reviewed
Feb 1, 2021
nicaurvi
approved these changes
Feb 1, 2021
bdpedigo
reviewed
Feb 1, 2021
bdpedigo
reviewed
Feb 1, 2021
bdpedigo
reviewed
Feb 1, 2021
bdpedigo
reviewed
Feb 1, 2021
|
@asaadeldin11 can you resolve all open comments so we can merge? would like to use this for something |
asaadeldin11
commented
Mar 19, 2021
|
looks like black failing |
should be resolved now |
bdpedigo
reviewed
Mar 29, 2021
|
@asaadeldin11 can you resolve conflicts and resolve any comments above that you addressed |
bdpedigo
reviewed
Apr 5, 2021
bdpedigo
reviewed
Apr 5, 2021
bdpedigo
reviewed
Apr 5, 2021
bdpedigo
approved these changes
Apr 5, 2021
|
@asaadeldin11 tests failing |
|
failing tests should be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #347
Allows
GraphMatchto accept a similarity matrix and perform similarity augmented graph matching.See notebook for proof of effectiveness