Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in GraphMatch docs #729

Merged
merged 1 commit into from Mar 14, 2021
Merged

Fix bug in GraphMatch docs #729

merged 1 commit into from Mar 14, 2021

Conversation

bdpedigo
Copy link
Collaborator

@bdpedigo bdpedigo commented Mar 11, 2021

  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

None

What does this implement/fix? Briefly explain your changes.

Fixes a bug in the GraphMatch docstring about initializations from the barycenter

Any other comments?

@asaadeldin11 this is no longer true at all, right?

@netlify
Copy link

netlify bot commented Mar 11, 2021

Deploy preview for graspologic ready!

Built with commit 6fe0e81

https://deploy-preview-729--graspologic.netlify.app

@bdpedigo bdpedigo changed the title Fix bug in docs Fix bug in GraphMatch docs Mar 11, 2021
@asaadeldin11
Copy link
Contributor

Yeah, no longer do this

@bdpedigo
Copy link
Collaborator Author

bdpedigo commented Mar 11, 2021

@asaadeldin11 just noticed something else while I'm here
Under init docstring

If 2d-array, init must be :math:m' x m', where :math:m' = n - m,
and it must be doubly stochastic: each of its rows and columns must
sum to 1.

I don't actually know what m' is? I assume the number of nonseeded vertices? I don't think we actually define there

@bdpedigo bdpedigo merged commit e465fa3 into dev Mar 14, 2021
@bdpedigo bdpedigo deleted the gm-doc-bug branch March 14, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants