Default weight to 1 for unweighted graph during n2v #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for graspologic failed. 🔨 Explore the source changes: ef55b46 🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/60d23d86834b26000741f48c |
nicaurvi
commented
May 18, 2021
nicaurvi
commented
May 18, 2021
daxpryce
reviewed
May 18, 2021
daxpryce
reviewed
May 18, 2021
daxpryce
reviewed
May 19, 2021
daxpryce
reviewed
Jun 22, 2021
daxpryce
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Embedding methods should handle unweighted graphs by defaulting the weight to 1. N2v was not behaving in the same way as the spectral methods -- this PR will fix that.
Closes #800
Any other comments?
I also added an explicity list() when returning the labels with a corresponding test as networkx graph.nodes() returns a NodeView rather than a list.