New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making layouts/auto.py work for directed graphs #807
Conversation
❌ Deploy Preview for graspologic failed. 🔨 Explore the source changes: 8a901ef 🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/61144728f14ee9000816a6e8 |
@dlee0156 just FYI the mypy type check and netlify checks are all expected to fail right now, but everything else should be passing once the builds all finish (as far as I know) |
@bdpedigo why is the netlify check expected to fail? what is going on with netlify right now? |
not totally sure - i'd need to get the netlify credentials from the lab to look into this. has been low priority for me just cause we've talked various times about having RTD or some other way of doing this that doesn't rely on netlify but IDK what our current thoughts on that are. netlify also stopped being as useful once the docs were split because the preview link that netlify posted no longer worked unless you knew to paste "references" after the url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, but I created #818 so we can make sure our type hinting and validations are keeping pace with us expanding our capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dlee0156! 🎉
Reference Issues/PRs
Fixes #655. See also #736.
What does this implement/fix? Briefly explain your changes.
layout_umap and layout_tsne works for directed graphs.
Any other comments?