Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LSE to Pipeline #817

Merged
merged 12 commits into from Aug 11, 2021
Merged

Add LSE to Pipeline #817

merged 12 commits into from Aug 11, 2021

Conversation

daxpryce
Copy link
Contributor

@daxpryce daxpryce commented Aug 10, 2021 •
edited

  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

This PR adds laplacian spectral embedding to the pipeline, similar to adding ase did in my last PR.

@netlify
Copy link

netlify bot commented Aug 10, 2021 •
edited

❌ Deploy Preview for graspologic failed.

🔨 Explore the source changes: f332e1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/611417c6750b4600083d7ede

@bdpedigo bdpedigo mentioned this pull request Aug 11, 2021
Open
bdpedigo
bdpedigo approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@bdpedigo bdpedigo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides adding a tutorial #820 and the changes to form I have suggested #395 , both of which sound like they'll be separate PRs.

@daxpryce daxpryce merged commit b4ce313 into dev Aug 11, 2021
jonmclean
jonmclean reviewed Aug 11, 2021
View reviewed changes
graspologic/pipeline/embed/adjacency_spectral_embedding.py
@@ -103,6 +103,11 @@ def adjacency_spectral_embedding(
-------
Embeddings

Raises
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I forgot about this.

@bdpedigo bdpedigo deleted the lse-pipeline branch August 11, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmclean jonmclean jonmclean left review comments

@bdpedigo bdpedigo bdpedigo approved these changes

@bryantower bryantower Awaiting requested review from bryantower

@nicaurvi nicaurvi Awaiting requested review from nicaurvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daxpryce @jonmclean @nicaurvi @bdpedigo