Change pass_to_ranks if statement to be self.pass_to_ranks instead of… #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for graspologic failed. 🔨 Explore the source changes: a8a6106 🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/61170bb2e085cf00084f3717 |
bdpedigo
approved these changes
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pass_to_ranks
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Right now the if statement is trivially satisfied becuase pass_to_ranks is defined as the utils function pass_to_ranks instead of the attribute pass_to_ranks.
this is a quick fix that changes the if statement to check the attribute self.pass_to_ranks instead of the function.
Any other comments?