Add omnibus_embedding_pairwise to pipeline module #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for graspologic failed. 🔨 Explore the source changes: d1c2aab 🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/611eaded4491d00007f4bc84 |
daxpryce
reviewed
Aug 19, 2021
daxpryce
reviewed
Aug 19, 2021
daxpryce
reviewed
Aug 19, 2021
daxpryce
approved these changes
Aug 19, 2021
bdpedigo
reviewed
Aug 19, 2021
Comment on lines
+154
to
+161
| # create a graph that contains all nodes and edges across the entire corpus | ||
| union_graph = graphs[0].copy() | ||
| for graph in graphs[1:]: | ||
| union_graph.add_edges_from(graph.edges()) | ||
|
|
||
| union_graph_lcc = largest_connected_component(union_graph) | ||
| union_graph_lcc_nodes = union_graph_lcc.nodes() | ||
| union_node_ids = np.array(list(union_graph_lcc_nodes)) |
There was a problem hiding this comment.
just wanted to mention that we have a util function for this here https://github.com/microsoft/graspologic/blob/07c78921491da596e9f438c740805c7a920aaa0d/graspologic/utils/utils.py#L584
There was a problem hiding this comment.
@nyecarr maybe you can use this in #824 too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Add wrapper api to omnibus and add the pairwise omni technique used in
topologicAny other comments?
Added a couple elbow cut tests for pipeline ase/lse just for peace of mind.