Improve speed of serializer test function #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test
function for the serializer plugin is called many times (from jest docs)Using the serializer for many elements causes a large slowdown due to the fact it constructs a large regex every time it's called
I believe this can be improved because
DEBUG_RESET_CLASSES
andDEFINITION_LOOKUP_TABLE
are maps so we should be able to lookup a class without doing a string searchThis PR changes the
test
function to use a faster implementationSimple benchmark test - https://jsperf.app/nevedi