Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for shorthands #544

Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Apr 23, 2024

This PR adds support for the most of CSS shorthands into @griffel/core.

See #531 for the explainer. Bundle size is increased as now bundle shorthand definitions, however the increase happens only for runtime version.

@layershifter layershifter requested a review from a team as a code owner April 23, 2024 14:56
@layershifter layershifter marked this pull request as draft April 23, 2024 14:56
Copy link

github-actions bot commented Apr 23, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
core
makeStyles (runtime)
21.852 kB
8.301 kB
25.905 kB
9.238 kB
4.053 kB
937 B
react
makeStyles (runtime)
24.357 kB
9.275 kB
28.41 kB
10.227 kB
4.053 kB
952 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
__resetStyles (makeResetStyles)
273 B
197 B
core
__styles (makeStyles)
1.727 kB
832 B
core
makeResetStyles (runtime)
17.14 kB
6.569 kB
core
mergeClasses
1.865 kB
900 B
core
shorthands.padding()
4.781 kB
1.537 kB
react
__css
1.723 kB
812 B
react
__styles
4.187 kB
1.832 kB
react
makeResetStyles (runtime)
19.64 kB
7.562 kB
react
makeStaticStyles (runtime)
9.576 kB
4.182 kB
shadow-dom
createShadowDOMRenderer
4.085 kB
1.724 kB
🤖 This report was generated against b4ed7ac5ab5b490e7a1b38a214c92af359aa3206

@layershifter layershifter force-pushed the feat/add-support-for-shorthands branch 4 times, most recently from 3fc86fb to 41a12b5 Compare April 23, 2024 15:57
@layershifter layershifter force-pushed the feat/add-support-for-shorthands branch 4 times, most recently from 5bfc214 to b2ac180 Compare April 24, 2024 13:16
@layershifter layershifter marked this pull request as ready for review April 24, 2024 13:24
@layershifter layershifter force-pushed the feat/add-support-for-shorthands branch from b2ac180 to 571af84 Compare April 30, 2024 14:20
@layershifter layershifter enabled auto-merge (squash) April 30, 2024 15:13
@layershifter layershifter merged commit 0f2eb5e into microsoft:main Apr 30, 2024
4 checks passed
@layershifter layershifter deleted the feat/add-support-for-shorthands branch April 30, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant