fix(core): fix hash collisions with at rules #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
ling1726
approved these changes
May 21, 2024
ling1726
reviewed
May 21, 2024
ling1726
reviewed
May 21, 2024
| export function hashPropertyKey(selector: string, property: string, atRules: AtRules): PropertyHash { | ||
| // uniq key based on property & selector, used for merging later | ||
| const computedKey = selector + atRules.container + atRules.media + atRules.supports + property; | ||
| const computedKey = selector + atRulesToString(atRules) + property; |
There was a problem hiding this comment.
previously layer queries were not supported in hashPropertyKey I guess it was unintentional?
There was a problem hiding this comment.
No, it's a bug #561.
layershifter
force-pushed
the
fix/hash-collisions
branch
from
25b9b9c
to
6d8afc9
Compare
Co-authored-by: ling1726 <lingfangao@hotmail.com>
layershifter
force-pushed
the
fix/hash-collisions
branch
3 times, most recently
from
b7d0560
to
6e18794
Compare
layershifter
force-pushed
the
fix/hash-collisions
branch
from
6e18794
to
7ef767a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issues for reproductions:
Adds prefixes for at rules in hashes so they will be unique.