fix: introduce modern typings for TS >4 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Mar 10, 2022
layershifter
commented
Mar 10, 2022
layershifter
force-pushed
the
fix/make-typings-better
branch
from
9f9b5f3
to
d6b74a9
Compare
馃搳 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
fix/make-typings-better
branch
2 times, most recently
from
7648ba4
to
15872f7
Compare
layershifter
commented
Jul 14, 2023
| @@ -3,7 +3,7 @@ import * as logSymbols from 'log-symbols'; | |||
|
|
|||
| export function createTempDir(prefix: string) { | |||
| // "Unsafe" means delete even if it still has files inside (our desired behavior) | |||
| const tempDir = tmp.dirSync({ prefix: 'nextjs', unsafeCleanup: true }).name; | |||
| const tempDir = tmp.dirSync({ prefix, unsafeCleanup: true }).name; | |||
layershifter
force-pushed
the
fix/make-typings-better
branch
from
15872f7
to
5340af4
Compare
layershifter
commented
Jul 14, 2023
| @@ -0,0 +1,6 @@ | |||
| export type { GriffelAnimation, GriffelStyle } from './makeStyles'; | |||
There was a problem hiding this comment.
Copied from previous typings.
layershifter
force-pushed
the
fix/make-typings-better
branch
from
5340af4
to
d3be1f9
Compare
ling1726
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378.
This PR introduces modern typings for TypeScript 4.1 and higher as this version supports recursive types references. This allow to simplify typings and remove weird workarounds. Also newer typings make TS errors more precise (check changes in the fixtures) 馃憤
To keep compatibility with older versions of TS older typings are kept as legacy. To resolve them
typesVersionsfield is used.