This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Fix HLS streaming (use AdaptiveMediaSource instead of MediaSource) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return MediaSource.CreateFromUri(new Uri(streamUrl)); | ||
| return MediaSource.CreateFromAdaptiveMediaSource(mediaSource); |
There was a problem hiding this comment.
you should only do this for hls content types
| @@ -61,7 +65,7 @@ public PlayerViewModel(IGrooveClient grooveClient, GrooveApiErrorViewModel error | |||
|
|
|||
| if (!string.IsNullOrEmpty(streamResponse.Url)) | |||
| { | |||
| StreamUrl = streamResponse.Url; | |||
| MediaSource = (await AdaptiveMediaSource.CreateFromUriAsync(new Uri(streamResponse.Url))).MediaSource; | |||
| } | |||
There was a problem hiding this comment.
It would be interesting to add a comment to explain why this is needed
antoinecellerier
suggested changes
Feb 21, 2017
bfreydier
force-pushed
the
fixhlsstreaming
branch
from
79fcc68
to
45060aa
Compare
daauro
reviewed
Feb 21, 2017
| MediaSource = | ||
| streamResponse.ContentType == "application/vnd.apple.mpegurl" | ||
| ? MediaSource.CreateFromAdaptiveMediaSource( | ||
| (await AdaptiveMediaSource.CreateFromUriAsync(streamResponseUri)).MediaSource) |
There was a problem hiding this comment.
(await AdaptiveMediaSource.CreateFromUriAsync(streamResponseUri)).MediaSource) [](start = 28, length = 78)
in the sample codes we saw this morning on the interwebs everyone seemed to check if the AdaptiveMediaSource had a success status before passing it to the MediaSource, do you know if that's important?
|
|
bfreydier
force-pushed
the
fixhlsstreaming
branch
from
45060aa
to
9c9d2f5
Compare
| } | ||
| } | ||
|
|
||
| private async Task<MediaSource> GetMediaSource(Uri streamUri, string contentType) |
There was a problem hiding this comment.
Please add a comment explaining why this is needed
antoinecellerier
approved these changes
Feb 21, 2017
bfreydier
force-pushed
the
fixhlsstreaming
branch
from
9c9d2f5
to
a9236a9
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.