Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template specialization for ArrayViewTypeTraits uses incorrect static member of is_reference #71

Closed
kernhanda opened this issue Sep 27, 2015 · 1 comment
Closed

Template specialization for ArrayViewTypeTraits uses incorrect static member of is_reference #71

kernhanda opened this issue Sep 27, 2015 · 1 comment

Comments

@kernhanda
Copy link
Contributor 

struct ArrayViewTypeTraits<Traits, typename std::is_reference<typename Traits::array_view_traits &>::type>

std::is_reference<T>::type isn't valid. It should be using std::is_reference<T>::value.
@kernhanda kernhanda mentioned this issue Sep 27, 2015
Closed
@neilmacintosh
Copy link
Collaborator

I believe there is a member type on is_reference called "type" (see http://en.cppreference.com/w/cpp/types/is_reference). So the usage looks valid to me.

kivadiu added a commit to kivadiu/GSL that referenced this issue Aug 22, 2018
@kivadiu
Allow #include <gsl/...> without repeating gsl
afc6343 
Headers are named inconsistently: algorithm, assert, byte and util
headers are prefixed with gsl_. This is to avoid name clash with
standard headers for people including directly from the gsl directory.

However, for people including from the parent directory of gsl, in
addition to looking inconsistent, this also looks redundant:
#include <gsl/gsl_assert>

This adds algorithm, assert, byte and util headers that just forward to
gsl_ headers. It is then possible to include like this:
#include <gsl/assert>

Fixes microsoft#71
@kivadiu kivadiu mentioned this issue Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow #include <gsl/...> without repeating gsl kivadiu/GSL
2 participants
@kernhanda @neilmacintosh