Add DnsSettings to ncproxy CreateEndpointRequest #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
changed the title
|
|
dcantah
force-pushed
the
ncproxy-dns
branch
3 times, most recently
from
7e13d2c
to
47cb0b9
Compare
katiewasnothere
approved these changes
Jun 3, 2021
To be able to set DNS configurations on the endpoint add a new DnsSettings message to be used on the hcn endpoint. This PR also fixes up a spelling mistake in subnet_ipadress_prefix -> subnet_ipaddress_prefix, and a couple casing changes on the proto file. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to set DNS configurations on the endpoint add a new DnsSettings message to be used on the hcn endpoint.
This PR also fixes up a spelling mistake in subnet_ipadress_prefix -> subnet_ipaddress_prefix, and a couple casing changes on the proto file.
Signed-off-by: Daniel Canter dcanter@microsoft.com