Restructure location of various ncproxy apis #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
restructure_ncproxy_apis
branch
from
3ba1e7c
to
4a6873a
Compare
dcantah
reviewed
Nov 10, 2021
dcantah
reviewed
Nov 10, 2021
|
lgtm besides the two small comments |
katiewasnothere
force-pushed
the
restructure_ncproxy_apis
branch
from
4a6873a
to
2b756cf
Compare
…nges Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
restructure_ncproxy_apis
branch
from
2b756cf
to
c40eb70
Compare
dcantah
reviewed
Nov 22, 2021
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
dcantah
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves around some of the ncproxy apis to accommodate future changes. In particular this change was made to allow for supporting multiple versions of both the nodenetsvc and ncproxygrpcs service apis.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com