Ignore access denied on HcsTerminateProcess #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
ignore-access-denied-on-kill
branch
2 times, most recently
from
0bd84c5
to
51ed656
Compare
|
This looks good to me; though I am not sure why |
|
Oop @gabriel-samfira beat me to it |
|
make sure to |
When calling HcsTerminateProcess on a process that has exited, but we still have open handles to, an ERROR_ACCESS_DENIED may be returned. https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
ignore-access-denied-on-kill
branch
from
51ed656
to
98c1b41
Compare
done! Thanks! |
dcantah
approved these changes
Dec 23, 2021
anmaxvl
approved these changes
Dec 24, 2021
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
When calling HcsTerminateProcess on a process that has exited, but we still have open handles to, an ERROR_ACCESS_DENIED may be returned. https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com> (cherry picked from commit 58caeed) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
added a commit
that referenced
this pull request
Jan 4, 2022
When calling HcsTerminateProcess on a process that has exited, but we still have open handles to, an ERROR_ACCESS_DENIED may be returned. https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com> (cherry picked from commit 58caeed) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
3 tasks
|
@dcantah @jsturtevant do you know whether we can pick this fix in docker? |
Rather than this PR, I suggest looking at: #1275 Actually, I would suggest to have a look at all the fixes merged in 0.9.2: https://github.com/microsoft/hcsshim/releases/tag/v0.9.2 if those fixes are not currently present in docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling HcsTerminateProcess on a process that has exited, but we still have open handles to, an ERROR_ACCESS_DENIED may be returned.
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks
Fixes: #1251