Rename conpty.New to conpty.Create #1254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames conpty.New, the method used to create a new ConPTY object, to Create instead. Mostly preference and to stay in line with what we'd named the method for creating a job object. The windows API used to create the pty is 'CreatePseudoConsole' so to me it makes more sense and would be more familiar to folks if this was ever moved out of /internal for outside use.