Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redundant conpty.ConPTY struct name #1259

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented Dec 29, 2021

This change renames the ConPTY struct in the conpty package to just Pty

This change renames the ConPTY struct in the conpty package to
Pty.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah dcantah requested a review from a team as a code owner December 29, 2021 22:11
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the tests pass

@helsaawy
Copy link
Contributor

LGTM

@dcantah dcantah merged commit 3f2848a into microsoft:master Dec 30, 2021
dcantah added a commit to dcantah/hcsshim that referenced this pull request Jan 4, 2022
This change renames the ConPTY struct in the conpty package to
Pty.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
(cherry picked from commit 3f2848a)
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants