Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold lock when updating DefaultMounts #1367

Merged
merged 1 commit into from Apr 26, 2022
Merged

Hold lock when updating DefaultMounts #1367

merged 1 commit into from Apr 26, 2022

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Apr 22, 2022

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl anmaxvl requested a review from a team as a code owner April 22, 2022 00:48
@anmaxvl
Hold lock when updating DefaultMounts
7fe8354 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the fix/extend-default-mounts-hold-lock branch from 537905b to 7fe8354 Compare April 22, 2022 00:48
@helsaawy
Copy link
Contributor

It feels weird to mutex-guard exported fields in an exported struct, since users can bypass the mutex and violate assumptions.
Do we want to rework it so that pe.DefaultMounts, .Containers, and co are private and use methods that return copies instead?

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Apr 22, 2022

not a bad idea, but I'd prefer implementing it as a separate PR, if you don't mind.

@anmaxvl anmaxvl merged commit a3a8aa1 into microsoft:master Apr 26, 2022
@anmaxvl anmaxvl deleted the fix/extend-default-mounts-hold-lock branch April 26, 2022 21:16
anmaxvl added a commit that referenced this pull request Feb 7, 2023
@anmaxvl
Merged PR 6117553: Sync ADO to 671ec23
6342f80 
Sync ADO to 671ec23

Related work items: #1258, #1273, #1304, #1359, #1360, #1362, #1363, #1367, #1372, #1374, #1377, #1380, #1381, #1382, #1384, #1387, #1388, #1389, #1390, #1391, #1393, #1394, #1395, #1396, #1398, #1400, #1401, #1402, #1404, #1406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@helsaawy helsaawy helsaawy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmaxvl @helsaawy @dcantah