Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lcow driver installation path #1383

Merged

Conversation

katiewasnothere
Copy link
Contributor

  • update install-drivers tool to take in additional parameter for
    driver read/write path
  • update call to install-drivers to take in new param
  • update nvidia hook to use CreateRuntime instead of Prestart hook

This PR removes the need for a separate set of boot files for gpu code paths

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner April 28, 2022 02:47
@dcantah
Copy link
Contributor

dcantah commented Apr 28, 2022

Failin on verify-test-vendor

@ghost
Copy link

ghost commented Apr 28, 2022

CLA assistant check
All CLA requirements met.

cmd/gcstools/installdrivers.go Show resolved Hide resolved
internal/devices/drivers.go Show resolved Hide resolved
internal/hooks/spec.go Outdated Show resolved Hide resolved
@katiewasnothere katiewasnothere force-pushed the remove_nvidia_boot_files branch 2 times, most recently from 0687641 to 22b8476 Compare June 28, 2022 23:40
@katiewasnothere
Copy link
Contributor Author

Rebased and force pushed to rerun the CI

cmd/gcstools/installdrivers.go Outdated Show resolved Hide resolved
internal/devices/drivers.go Outdated Show resolved Hide resolved
@katiewasnothere
Copy link
Contributor Author

Rebased

Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once CI is green

- update `install-drivers` tool to take in additional parameter for
driver read/write path
- update call to `install-drivers` to take in new param
- update nvidia hook to use CreateRuntime instead of Prestart hook

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere merged commit 7555bd5 into microsoft:main Sep 8, 2022
@katiewasnothere katiewasnothere deleted the remove_nvidia_boot_files branch September 8, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants