Fix golangci-lint issues #1480
Merged
Fix golangci-lint issues #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
fix-lint-issues
branch
from
030984c
to
7df155b
Compare
helsaawy
requested changes
Aug 12, 2022
kevpar
reviewed
Aug 12, 2022
kevpar
reviewed
Aug 12, 2022
kevpar
reviewed
Aug 12, 2022
kevpar
reviewed
Aug 12, 2022
anmaxvl
approved these changes
Aug 12, 2022
kevpar
reviewed
Aug 12, 2022
|
So obviously there's a ton of messed up comment formatting. Are you still investigating this? |
|
Yea.. I thought this was on draft if I'm being honest 😿Hamza's comments let me know this was not the case haha. I haven't looked at this since this morning, but I'm looking now. Need to find what gofmt doesn't like anymore |
dcantah
force-pushed
the
fix-lint-issues
branch
3 times, most recently
from
2c634c1
to
c09675e
Compare
helsaawy
approved these changes
Aug 14, 2022
anmaxvl
approved these changes
Aug 16, 2022
Gets rid of io/ioutil usage in favor of the os and io replacements. ioutil has been deprecated since 1.16. This additionally starts to use t.TestDir() in some tests instead which is a nice side effect. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
We had a stray use of syscall.Syscall that should be in winapi with the rest of our defs. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
We're reworking the hcs/errors package soon, but in the meantime don't lint the use of the deprecated err.Temporary. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
gofmt -s on go 1.19 Signed-off-by: Daniel Canter <dcanter@microsoft.com>
v3 golangci-lint action removed the skip-go-installation flag and now explicitly requires using the setup-go action to function. - Get rid of skip-go-installation - Swap to v3 of setup-go - Remove only-new-issues usage Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
fix-lint-issues
branch
from
c09675e
to
bf8bdb0
Compare
|
Squashed, will wait for CI to finish again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an upgrade to our linter comes a lot of new yelling at us. This does quite a bit:
t.TempDir()which was a nice side effect.and not call
syscall.Syscalldirectly.net.Error.Temporaryusage for now.net.Error's temporary method is deprecated since 1.18 but we make sureHcsError,ProcessErrorandSystemErrorall adhere tonet.Error's interface which contains theTemporarymethod. We're reworking the hcs errors package shortly and I'm not sure of the history or significance behind that choice. This seems sane for now.