Enable linting on test directory #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
force-pushed
the
he/ci-tests
branch
7 times, most recently
from
cd5489f
to
6c01695
Compare
anmaxvl
reviewed
Sep 1, 2022
Updated CI to lint from within test directory. Currently, it does not since it is a different module. Additionally, golangci-lint uses `GOOS` to decide what files to evaluate, so matrix was upddated with GOOS. Updated lint config to analyze test files, both within `./test` with `functional` tag, and unit tests with `integration` tag. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Removed unnecessary code, added exceptions for most issues. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
he/ci-tests
branch
from
6c01695
to
1cbf1a2
Compare
kiashok
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently linting is not run on files with the
admin,functional, orintegrationbuild constraints, which precludes test files withinhcnand./internal/safefiles.Additionally,
golanglint-cionly processes a module, so it does not lint the./testdirectory.This PR updates the CI to run both from the root and from within the
testmodule.Additionally, it updates the build tags used by the linters, excludes the files within
cri-containerd/test-images(since they are just used for building docker images to test with), and ignores linting errors that the package namecri-containerdis invalid because of the-.Finally, the second commit updates files to conform to the linter.