Fix SCSI mount error handling #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
approved these changes
Feb 3, 2023
katiewasnothere
approved these changes
Feb 3, 2023
ambarve
force-pushed
the
scsi_changed_errcheck
branch
from
a4a3118
to
2d1458f
Compare
katiewasnothere
approved these changes
Feb 3, 2023
SCSI mount operation used to check for ENOENT ("no such file or directory") error and used to retry the mount
operation because the SCSI device sometimes takes a bit of a time to show up. However, in the recent version
of the Linux kernel the error it returns seems to have changed from ENOENT to ENXIO ("no such device or
address"). This commit updates the retry logic to retry for either of those errors.
This also updates a test that used to specifically look for 2000 bits of entropy inside the guest.
However, Linux kernel 5.15 has changed the entropy behavior and now it only has 256 bits of entropy (with
increased security and performance).
Signed-off-by: Amit Barve <ambarve@microsoft.com>
ambarve
force-pushed
the
scsi_changed_errcheck
branch
from
2d1458f
to
b0c2088
Compare
anmaxvl
approved these changes
Feb 3, 2023
katiewasnothere
pushed a commit
to katiewasnothere/hcsshim
that referenced
this pull request
Feb 10, 2023
Related work items: microsoft#1642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCSI mount operation used to check for ENOENT ("no such file or directory") error and used to retry the mount operation because the SCSI device sometimes takes a bit of a time to show up. However, in the recent version of the Linux kernel the error it returns seems to have changed from ENOENT to ENXIO ("no such device or address"). This commit updates the retry logic to retry no matter the error code so that even if the error code changes in the future this won't break.
This also updates a test that used to specifically look for 2000 bits of entropy inside the guest. However, Linux kernel 5.15 has changed the entropy behavior and now it only has 256 bits of entropy (with increased security and performance).
Signed-off-by: Amit Barve ambarve@microsoft.com