Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide error message when the lack of required environment variable causes policy denial #1661

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Provide error message when the lack of required environment variable causes policy denial #1661

merged 1 commit into from
Feb 19, 2023

Conversation

SeanTAllen
Copy link
Contributor

This commit handles the simplest case of error reporting and doesn't inform as to the particular variables or the group them into sets based on container/process.

Signed-off-by: Sean T. Allen seanallen@microsoft.com
Signed-off-by: Matthew A Johnson matjoh@microsoft.com

@SeanTAllen SeanTAllen requested a review from a team as a code owner February 14, 2023 16:39
@SeanTAllen
Copy link
Contributor Author

Follow on PRs will be coming but they require some legwork that will take some time.

Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can have a few helper functions in the framework to simplify rego code a bit... but maybe for next time.

pkg/securitypolicy/framework.rego Outdated Show resolved Hide resolved
@SeanTAllen
Copy link
Contributor Author

This has been rebased against main @anmaxvl

… causes policy denial

This commit handles the simplest case of error reporting and doesn't inform as the the
particular variables or the group them into sets based on container/process.

Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
@anmaxvl anmaxvl merged commit c97246d into microsoft:main Feb 19, 2023
@anmaxvl anmaxvl deleted the required-env-error-message branch February 19, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants