Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify zeroDevice to just zero first block #1672

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Feb 23, 2023

No description provided.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl requested a review from a team as a code owner February 23, 2023 09:20
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aside for error nit and Scott's comment

internal/guest/storage/crypt/utilities.go Outdated Show resolved Hide resolved
Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl merged commit 38a2b19 into microsoft:main Feb 28, 2023
@anmaxvl anmaxvl deleted the simplify-zero-device branch February 28, 2023 06:01
KenGordon pushed a commit to KenGordon/hcsshim that referenced this pull request May 17, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 38a2b19)
KenGordon pushed a commit to KenGordon/hcsshim that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants