fix: bug potentially not removing RW device. #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
Apr 18, 2023
internal/guest/runtime/hcsv2/uvm.go
Outdated
| @@ -538,7 +538,7 @@ func (h *Host) CreateContainer(ctx context.Context, id string, settings *prot.VM | |||
| return c, nil | |||
| } | |||
|
|
|||
| func (h *Host) modifyHostSettings(ctx context.Context, containerID string, req *guestrequest.ModificationRequest) (err error) { | |||
| func (h *Host) modifyHostSettings(ctx context.Context, containerID string, req *guestrequest.ModificationRequest) (retErr error) { | |||
There was a problem hiding this comment.
I'm missing where retErr is ever written to?
There was a problem hiding this comment.
Oh, interesting. The retErr is assigned to as part of the return. For anyone else confused like I was:
https://go.dev/play/p/IDH-93ODPLs
msscotb
reviewed
Apr 21, 2023
Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.