Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding padding to base64 encoded policy decisions #1738

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

matajoh
Copy link
Member

@matajoh matajoh commented Apr 18, 2023

This commit switches from raw encoding (no padding) to standard encoding (padding with =) for base64-encoded policy decisions.

Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
@matajoh matajoh requested a review from a team as a code owner April 18, 2023 09:39
@darracott
Copy link
Contributor

darracott commented Apr 18, 2023

Looks fine - and just to attach the motive behind this PR from discussions yesterday: .Net component fails to decode unpadded base64.

Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
@anmaxvl anmaxvl merged commit d816cbe into microsoft:main Apr 20, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants