Clean up NVIDIA hook #1879
Merged
Clean up NVIDIA hook #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
kabaldau/clean_up_nvidia_hook
branch
4 times, most recently
from
7a5f39d
to
5d3dc01
Compare
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/clean_up_nvidia_hook
branch
from
5d3dc01
to
25d6bdb
Compare
helsaawy
approved these changes
Sep 1, 2023
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/clean_up_nvidia_hook
branch
from
25d6bdb
to
ee73d47
Compare
anmaxvl
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the support for NVIDIA GPUs. Instead of relying on a separate VHD that contains the NVIDIA drivers to be mounted into the UVM at runtime, we assume the UVM image has the drivers and necessary tools (such as libnvidia-container's cli binary) already present.
annotations.GPUVHDPathis no longer used and will be removed in the future. Functional tests and cri-containerd tests have been cleaned up for this new logic.