uvmboot and gcs.test bug fix #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/gcs/main_test.go
Outdated
| @@ -177,10 +167,10 @@ func getHost(_ context.Context, tb testing.TB, rt runtime.Runtime) *hcsv2.Host { | |||
|
|
|||
| func getHostErr(rt runtime.Runtime, tp transport.Transport) (*hcsv2.Host, error) { | |||
| h := hcsv2.NewHost(rt, tp, &securitypolicy.ClosedDoorSecurityPolicyEnforcer{}, os.Stdout) | |||
There was a problem hiding this comment.
why do we use the closed door policy here?
There was a problem hiding this comment.
I think originally the gcs started with it, so i copied it for consistency?
Ill change it to open door as well, since that matches the default of what gcs does now
Fix bugs: - Using `boot-files-path` flag name instead of value - Explicitly passing open door policy instead of empty string Functional gcs tests also passed in encoded open door policy string, which is no longer necessary. Remove unnecessary else blocks. Pass context through calls. Use `log.G(ctx)` instead of `logrus`. Rename variables `cmd` and `scsi` to avoid overshadowing package names. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
uvmboot-bug
branch
from
69e4c0a
to
6aabaf9
Compare
anmaxvl
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs:
boot-files-pathflag name instead of valueFunctional gcs tests also passed in encoded open door policy string, which is no longer necessary.
Remove unnecessary else blocks.
Pass context through calls.
Use
log.G(ctx)instead oflogrus.Rename variables
cmdandscsito avoid overshadowing package names.