Check for SNP before fetching SNP report #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Powell <joepowell@microsoft.com>
helsaawy
approved these changes
Nov 13, 2023
anmaxvl
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR1886 changed the error type returned by the fetch SNP report code.
It transpires that when validating host data, we would always try to fetch the SNP report, even in non SNP mode, where we expect to get back an os.IsNotExist error and ignore it.
After PR1886 the SNP report fetch no longer returns an os.IsNotExist and so the new error is not ignored. This PR removes the reliance on the os.IsNotExist error.