Fix CodeQL code scanning alerts #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CodeQL alerts for unchecked downcasts from `int`s are to `(u)int32` (or `uintptr`) without checking for overflow. This can (potentially) cause incorrect behavior due to the value wrapping around to an unexpected value. Alerts: https://github.com/microsoft/hcsshim/security/code-scanning?query=branch%3Amain+rule%3Ago%2Fincorrect-integer-conversion Issue description: https://cwe.mitre.org/data/definitions/190.html https://cwe.mitre.org/data/definitions/681.html Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
changed the title
anmaxvl
approved these changes
Nov 20, 2023
katiewasnothere
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CodeQL alerts for unchecked downcasts from
ints are to(u)int32(oruintptr) without checking for overflow. This can (potentially) cause incorrect behavior due to the value wrapping around to an unexpected value.Alerts:
https://github.com/microsoft/hcsshim/security/code-scanning?query=branch%3Amain+rule%3Ago%2Fincorrect-integer-conversion
Issue description:
https://cwe.mitre.org/data/definitions/190.html
https://cwe.mitre.org/data/definitions/681.html