Minor CimFS bug fixes #1980
Merged
Minor CimFS bug fixes #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Barve <ambarve@microsoft.com>
Currently, ExpandScratchSize or ExpandSandboxSize functions expand the VHD itself but don't expand the volume on that VHD (unless we are on 19H1 & build < 19020). This works because for legacy layers the PrepareLayer call made just before starting the container will automatically expand the volume to match the size of the VHD. However, in case of CimFS layers we don't call PrepareLayer at all, so in that case we need to expand the volume at the time of expanding the VHD. This also means in case of legacy layers, we might have a small perf hit because the VHD is mounted twice for expansion (once here and once during the PrepareLayer call). But as long as the perf hit is minimal, we should be okay. Signed-off-by: Amit Barve <ambarve@microsoft.com>
msscotb
approved these changes
Dec 18, 2023
katiewasnothere
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minor bug fixes to CimFS writer and also correctly updates the windows OS build that adds support for CimFS.